docsifyjs / docsify

🃏 A magical documentation site generator.
https://docsify.js.org
MIT License
27.51k stars 5.67k forks source link

No docisfy.min.esm.js generated #1435

Open jcayzac opened 3 years ago

jcayzac commented 3 years ago

Bug Report

No docsify.esm.js or docsify.min.esm.js is generated by the build script although they're mentioned at:

https://github.com/docsifyjs/docsify/blob/da9af18c4e4aa8b2c42773a01104f5a7c0a628a4/src/core/global-api.js#L12

Modules have been supported by all browsers for 2 years. Please give us a module 😄

Steps to reproduce

curl https://unpkg.com/docsify@4.11.6/lib/docsify.esm.js

What is current behaviour

404 Not Found

What is the expected behaviour

200 OK

Other relevant information

Please create a reproducible sandbox

Edit 307qqv236

Mention the docsify version in which this bug was not present (if any)

sy-records commented 3 years ago

Should be added in v5? @trusktr

// TODO This is deprecated, kept for backwards compatibility. Remove in next
// major release. We'll tell people to get everything from the DOCSIFY global
// when using the global build, but we'll highly recommend for them to import
// from the ESM build (f.e. lib/docsify.esm.js and lib/docsify.min.esm.js).
trusktr commented 3 years ago

@sy-records Adding this is a non-breaking change. We could add it any time.

For v4, it would still create globals (but also export the globals for convenience of importing). For v5, there would be no globals.