chore: update miscellaneous parts of the source to reasonably modern language alternatives, remove polyfills, improve some JSDoc comments, remove traces of IE

trusktr commented 1 year ago

Continues from

https://github.com/docsifyjs/docsify/pull/2109 (review that one first)

Part of

https://github.com/docsifyjs/docsify/issues/2104

Summary

Updated a bunch of pieces of code to using modern patterns. Avoided refactoring, mostly changes happened inline, or were small refactorings only.

Some things that we updated:

var -> let/const
function () {} -> () => {}
merge() -> Object.assign()
a.concat(b) -> [...a, ...b]
Object.assign({}, a, b) -> {...a, ...b}
(function() {...})() -> {...}
[].slice.call(a) -> Array.from(a)
hasOwn(a, b) -> Object.keys(a).includes(b)
for (let i = 0; i<len; i++) const item = arr[i] -> for (const item of arr)
{foo: function() {}} -> {foo() {}}
"..." + a + "..." -> `...${a}...`
etc

Deleted

CSS var polyfill
replaceState/pushState fallback
IE fallbacks

BREAKING: In a minority of cases syntax updates may break apps running in very old browsers (such as Internet Explorer), or apps that build Docsify in a custom way with old build tools. To upgrade, build Docsify for older browsers in a custom way, or update existing build tools to handle newer syntax.

DEPRECATED: $docsify.themeColor is deprecated and will be eventually removed, use a --theme-color CSS variable in your style sheet.

What kind of change does this PR introduce?

Code style update Refactor Docs

For any code change,

[x] Related documentation has been updated if needed
[x] Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

[x] Yes (see above)
[ ] No

Related issue, if any:

Simplification and modernization issue: https://github.com/docsifyjs/docsify/issues/2104

Tested in the following browsers:

[x] Chrome
[x] Firefox
[x] Safari
[x] Edge
[ ] IE

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docsify-preview	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 16, 2023 5:30pm

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b621e0e4e7bedcef6d647947d4662d455e45048e:

Sandbox	Source
docsify-template	Configuration

trusktr commented 1 year ago

If someone disapproves and prefers to remove changes like for(;;)->for(of), etc, we can do that.

All the current features are well supported in browsers today, all tests pass, and the deployment looks good!

Note: The Vue feature has not been working in Vercel deployments for quite some time. It has been broken in Vercel since before any of my recent changes (before delete-ssr). I'm not sure if it was always broken or when it broke.

docsifyjs / docsify