When no fetchis done, the active sidebar element is not updated when a link is clicked. This is changed in this commit by calling getAndActive in $resetEvents.
This is shown in the videos below. In both videos, the 'QuickStart' sidebar element was selected, then the 'Initialize' sub-sidebar child of 'Quickstart' and then the parent sidebar element, 'Quickstart' again.
Current behavior
Clicking on a sub-sidebar, then clicking on the parent sidebar again results in no element being 'active' .
Summary
When no
fetch
is done, the active sidebar element is not updated when a link is clicked. This is changed in this commit by calling getAndActive in$resetEvents
.This is shown in the videos below. In both videos, the 'QuickStart' sidebar element was selected, then the 'Initialize' sub-sidebar child of 'Quickstart' and then the parent sidebar element, 'Quickstart' again.
Current behavior
Clicking on a sub-sidebar, then clicking on the parent sidebar again results in no element being 'active' .
Screencast from 14.07.2023 17:51:07.webm
Behavior after fix
Clicking on a sub-sidebar, then clicking on the parent sidebar again results in the sidebar element being 'active' .
Screencast from 14.07.2023 17:50:45.webm
What kind of change does this PR introduce?
Bugfix
Does this PR introduce a breaking change? (check one)
Related issue, if any:
Tested in the following browsers: