search

docsifyjs / docsify

🃏 A magical documentation site generator.
https://docsify.js.org
MIT License
27.78k stars 5.68k forks source link

Sidebar and navbar path configs need to take into account the routerMode #2133

Open trusktr opened 1 year ago

trusktr commented 1 year ago

PR https://github.com/docsifyjs/docsify/pull/1970 adds more documentation on how routerMode currently affects sidebar and navbar loading.

Ideally, there should not be any difference, and the sidebar and navbars paths should be determined in the same way no matter the routerMode.

With hash router mode, it seems that the paths are determined from the base of the site, whereas with history router mode, the paths are determined based on the current page path.