Closed trusktr closed 3 months ago
After making the change in
I can see the full error in the output, and the script no longer exits with 0 after the error (it should exit non-zero if there's an error):
PS D:\src\lume+lume\packages\docsifyjs+docsify> node .\build\emoji.js
Build emoji
- Fetching emoji data from https://api.github.com/emojis
- Retrieved 1877 emoji entries
file:///D:/src/lume+lume/packages/docsifyjs+docsify/build/emoji.js:47
const emojiMarkdownStart = emojiMatch[1].trim();
^
TypeError: Cannot read properties of null (reading '1')
at writeEmojiPage (file:///D:/src/lume+lume/packages/docsifyjs+docsify/build/emoji.js:47:40)
at file:///D:/src/lume+lume/packages/docsifyjs+docsify/build/emoji.js:101:3
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Node.js v20.5.0
I updated the PR so it also fixes the Windows issue. I'm not sure exactly how the issue happens, but I think it might be due to git settings.
I think that the other PR,
may prevent the CRLFs from popping in unexpectedly, but no harm in making the regex more robust just in case the CRLFs get in there somehow.
@trusktr --
Can we close this now that #2288 and #2436 have been merged?
Bug Report
Steps to reproduce