docsifyjs / docsify

🃏 A magical documentation site generator.
https://docsify.js.org
MIT License
27.47k stars 5.67k forks source link

Keyboard focus is moving to the hidden elements present inside the collapsed hamburger menu. #2306

Closed msftedad closed 10 months ago

msftedad commented 10 months ago

Bug Report

Steps to reproduce

  1. Open the PWA Builder URL-https://docs.pwabuilder.com/#/ in Edge browser.
  2. PWA Builder page will appear.
  3. Collapse the hamburger menu.
  4. Now navigate from the top of the page.
  5. Observe the issue.

Current behaviour

Keyboard focus is moving to the hidden controls which is present inside the collapse hamburger menu.

Attachments:

https://github.com/docsifyjs/docsify/assets/93735775/fc7f4b2b-3b77-4f14-a194-2ba620704920

https://github.com/docsifyjs/docsify/assets/93735775/f23cd107-b506-46c9-8cce-c8424de89c36

Expected behaviour

Keyboard focus should not move inside the hamburger menu when it is in collapsed state.

Other relevant information

Please create a reproducible sandbox

(https://codesandbox.io/static/img/play-codesandbox.svg)](https://codesandbox.io/s/307qqv236)](https://docs.pwabuilder.com/#/)

Mention the docsify version in which this bug was not present (if any)

NA

paulhibbitts commented 10 months ago

Thanks very much @msftedad for reporting this issue. I think the following PR (still to be released) addresses this issue https://github.com/docsifyjs/docsify/pull/2265

Could you please try the "Visit Preview" link in the PR and confirm? Thank you!

jhildenbiddle commented 10 months ago

Fixed via #2253 and #2265.

These updates will be available in the next release. Until then, you can verify the changes by visiting the develop branch preview.