docsifyjs / docsify

🃏 A magical documentation site generator.
https://docsify.js.org
MIT License
27.78k stars 5.68k forks source link

missed to copy files in docker image when building Dockerfile #2412

Closed joker7blue closed 6 months ago

joker7blue commented 6 months ago

Bug Report

missing COPY . . in docker file

Steps to reproduce

Current behaviour

The files are not copied to the docker image when building docker file, since we missed to COPY . .

Expected behaviour

The docsify project should run as expected after building from docker

Other relevant information

Please create a reproducible sandbox

Edit 307qqv236

Mention the docsify version in which this bug was not present (if any)

Koooooo-7 commented 6 months ago

Hi @joker7blue , it doesn't copy it into the Dockerfile, it mounts the files as volume instead. Hence, you can sync the live changes on time.

docker run -itp 3000:3000 --name=docsify -v $(pwd):/docs docsify/demo

If you wanna deploy your site via docker, either you put all your things inside the Docker image or mount it on runtime, thats both okay.

joker7blue commented 6 months ago

oh ok, Thanks for the explanation @Koooooo-7 👍🏽