docsifyjs / docsify

🃏 A magical documentation site generator.
https://docsify.js.org
MIT License
27.47k stars 5.67k forks source link

update(ci): add update emoji schedule workflow #2436

Closed Koooooo-7 closed 4 months ago

Koooooo-7 commented 4 months ago

Summary

Add update emoji schedule workflow to daily update emoji data. Changes:

Others:

close #2434

Related issue, if any:

What kind of change does this PR introduce?

Build-related changes

For any code change,

Does this PR introduce a breaking change?

No

Tested in the following browsers:

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 5:15am
Koooooo-7 commented 4 months ago

This looks great, @Koooooo-7. A few minor naming nitpicks, but otherwise this looks good.

I will update it.

Has this been tested? If not, it seems like we could by removing a data property entry from /src/core/render/emoji-data.js, committing the change, then waiting to see if this workflow generates the expected PR.

I tested it from a fork. ( the screenshot is gotten from that). And when we merge it into develop,we could manually trigger it for a test again.

And we don't need mock a emoji update since there already exists emoji update between our emojiData and github.

Koooooo-7 commented 4 months ago

Looks like @sy-records prefers we replace the git commands with actions, but otherwise this looks good to me.

I will negotiate with him and do the updates if needs.

jhildenbiddle commented 4 months ago

Sounds good, @Koooooo-7. Looks like this is ready to merge whenever you and @sy-records resolve the actions discussion. :)

Thanks for getting this up and running so quickly!