Closed Koooooo-7 closed 4 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
docsify-preview | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 24, 2024 5:15am |
This looks great, @Koooooo-7. A few minor naming nitpicks, but otherwise this looks good.
I will update it.
Has this been tested? If not, it seems like we could by removing a
data
property entry from/src/core/render/emoji-data.js
, committing the change, then waiting to see if this workflow generates the expected PR.
I tested it from a fork. ( the screenshot is gotten from that). And when we merge it into develop,we could manually trigger it for a test again.
And we don't need mock a emoji update since there already exists emoji update between our emojiData and github.
Looks like @sy-records prefers we replace the git commands with actions, but otherwise this looks good to me.
I will negotiate with him and do the updates if needs.
Sounds good, @Koooooo-7. Looks like this is ready to merge whenever you and @sy-records resolve the actions discussion. :)
Thanks for getting this up and running so quickly!
Summary
Add update emoji schedule workflow to daily update emoji data. Changes:
UTC 2:00
daily run, or manually trigger.build:emoji
out ofbuild
.try catch
fromemoji.js
to ensure thewriteJS
andwirteMarkdown
in sametransaction
(both success or failed), so, we could just check the last write file (src/core/render/emoji-data.js
) changes and add them all.update-emoji-data-$current_date-${last commit hash 7}
to be an unique branch commit, it makes it possible that we could manually trigger multi times in a day or it were be trigger both in schedule and manually does.Others:
build:emoji
inrelease.sh
since it is unlikely happen as per our discussion.close #2434
PR
Branch details
Related issue, if any:
What kind of change does this PR introduce?
Build-related changes
For any code change,
Does this PR introduce a breaking change?
No
Tested in the following browsers: