docsteer / sacnview

sACNView provides a tool for monitoring and sending the Streaming ACN lighting control protocol used for lighting control in theatres, TV studios and architectural systems
http://www.sacnview.org
Apache License 2.0
102 stars 24 forks source link

Crash on accessing source during removal from universe list. Was: Crashes when non-continuous frames are sent #68

Closed davek99 closed 6 years ago

davek99 commented 7 years ago

I am using the most recent build from your website (I did not build from git). V2.0.0-RC2 (June 11th, 0217). Running on Windows 7. Using a Raspberry Pi running https://www.openlighting.org/ola/ to send sACN via their Python API.

For me, sACNView periodically crashes when the sACN source sends only a frame or two of sACN. Seems to be just fine if sending continuous frames of sACN (about 100ms apart), but once that stops and goes back to only one (or periodic) frames the program crashes.

marcusbirkin commented 7 years ago

Hi,

Are you able to create a wireshark (https://www.wireshark.org/) log of the packets that can cause this issue?

Thanks,

Marcus

marcusbirkin commented 7 years ago

Not entirely resolved with #69

davek99 commented 7 years ago

Here is a wireshark file of what was happening when it crashes. Wireshark was started after my controller began sending sACN. When the controller stops, sACN View crashes. OLA Crashes sACN View txt.txt

marcusbirkin commented 7 years ago

Please see if this is resolved within RC3

marcusbirkin commented 7 years ago

Closing issue as no further reports of issues and I can no longer reproduce in recent builds

marcusbirkin commented 6 years ago

Same base issue still present in 2.0.1 RC2 Reproducer: () Start a source () Wait for the source to appear in universe list () Stop source () Repeatedly click on source in universe list () Crash as the source is removed

docsteer commented 6 years ago

Fix integrated in build 2.0.1 RC3