Closed GoogleCodeExporter closed 9 years ago
Thanks, patch looks good to me.
Rather than commit it myself, I think the time has come to give you commit
access (if you want it). Then you can commit this fix (and also issue 20).
Can you let me know your full email address?
Original comment by csilv...@gmail.com
on 12 Mar 2011 at 9:50
Commit access sounds great :) Of course I think it makes sense for me keep to
submitting patches for review for all but trivial compile fixes. I'm wary of
inadvertently breaking things for platforms I can't test directly.
I'm paul dot holden @gmail.com.
Original comment by paul.hol...@gmail.com
on 13 Mar 2011 at 12:18
OK, you should have commit powers now! Feel free to commit the patch -- you
can say that I reviewed it. (I agree it's a good idea to have someone else
sign off on the patch before committing -- google does pre-commit reviews
normally, so it's what I'm used to.)
Original comment by csilv...@gmail.com
on 14 Mar 2011 at 7:45
Fixed in r61
Original comment by paul.hol...@gmail.com
on 14 Mar 2011 at 9:43
Original issue reported on code.google.com by
paul.hol...@gmail.com
on 12 Mar 2011 at 4:07Attachments: