Closed GoogleCodeExporter closed 9 years ago
On Mac OS X IWYU works fine with and without this patch. Patch looks good to
me. But I think we should keep an eye on this code. IWYU doesn't perform JITing
and if JIT is required by Windows headers, I believe all JIT preparations will
be done by Clang itself. So I expect that this code will be unnecessary in the
future.
Original comment by vsap...@gmail.com
on 30 Jun 2013 at 5:38
Thanks for double-checking. Not sure what you mean by "JITing"? The code is
invoked as part of parsing inline assembly in winnt.h, there should be no code
generation going on.
Original comment by kim.gras...@gmail.com
on 30 Jun 2013 at 7:35
Fixed by r474.
Original comment by kim.gras...@gmail.com
on 30 Jun 2013 at 7:38
I've assumed that InitializeNativeTarget() is used for JIT from its usage. I've
encountered it in HowToUseJIT.cpp, ParallelJIT.cpp, clang-interpreter/main.cpp,
lli.cpp, llvm-jitlistener.cpp, JITEventListenerTest.cpp,
JITEventListenerTestCommon.h, JITTest.cpp, MCJITTestAPICommon.h.
Original comment by vsap...@gmail.com
on 30 Jun 2013 at 9:00
Ah, I see. I also noticed that the comment I copied mentioned JIT, maybe I
should update that to mention inline assembly parsing.
We could probably get away without initialising assembly generation as well.
I'll look into it.
Original comment by kim.gras...@gmail.com
on 1 Jul 2013 at 4:55
Original issue reported on code.google.com by
kim.gras...@gmail.com
on 26 Jun 2013 at 8:04Attachments: