Not scanning my whole collection

[TobbeT]

Hi,

Just found your Obsidian Discogs and I've been searching something like this for a while. I think I got everything right but this ./Setup -L /path/to/library doesn't work for me. I'm on Manjaro KDE Plasma and I have my whole music collection on an external drive like this: /mnt/HDD1_1TB/Music_Library/ and I run this Setup -L /mnt/HDD1_1TB/Music_Library and it just adds only two albums. I have almost 1000 songs in that location (38GB, 931 files and 85 subfolders). If I run it again, still get the same two records. As you can see on the screendump below. Any tips and tricks to share?

[doctorfree]

Hi, I am able to replicate this problem with a local music library. So, it's probably not something you have done wrong, Nor does it appear to be anything related to a mounted filesystem as my test was performed on the root filesystem. I doubt it's anything Manjaro related.

My ./Setup -L ~/Music only identified 7 artists of a medium size library. My first guess is a change in the Discogs API policy is throttling requests or timing out. I will look into it.

Thanks for the issue report.

[doctorfree]

Early tests indicate the problem may be album folder names. Note that the music library structure should be in the form Artist/Album but if an album name contains brackets it fails to get identified properly. For example, I had an artist/album folder named Father John Misty/[2017] Pure Comedy which was not getting added during Setup. I moved the album folder to Father John Misty/Pure Comedy and a subsequent run of Setup identified it properly.

I'm still trying to figure out what folder name characters are legal and how to pass that in the search url for api queries.

Do the albums in your library have something like [year] in the folder names? Or other special characters that might be causing problems?

Still investigating ...

[TobbeT]

Hi, and tanks for a quick support

My library looks like this:

AcDc/1976 Dirty Deeds Done Dirt Cheap

So I have the year first in the folder under artistfolder. I remove it and get back to you shortly.

Den tors 21 sep. 2023 00:38Ronald Record @.***> skrev:

Early tests indicate the problem may be album folder names. Note that the music library structure should be in the form Artist/Album but if an album name contains brackets it fails to get identified properly. For example, I had an artist/album folder named Father John Misty/[2017] Pure Comedy which was not getting added during Setup. I moved the album folder to Father John Misty/Pure Comedy and a subsequent run of Setup identified it properly.

I'm still trying to figure out what folder name characters are legal and how to pass that in the search url for api queries.

Do the albums in your library have something like [year] in the folder names? Or other special characters that might be causing problems?

Still investigating ...

— Reply to this email directly, view it on GitHub https://github.com/doctorfree/Obsidian-Custom-Discogs/issues/1#issuecomment-1728515241, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAASVDJDUQG56QUWJNYBAO3X3NV7VANCNFSM6AAAAAA5AKEEFY . You are receiving this because you authored the thread.Message ID: @.***>

[TobbeT]

I was wrong about the folder structure. I have like this (see attach image)

I removed the year in albumtitle for the first album and did a new setup thing. It found one more album (38 Special). Now I have removed the year in several albums and lets see if they get scanned.

Med vänliga hälsningar Torbjörn Törnqvist Litjärnberget 120 883 94 BACKE

Den tors 21 sep. 2023 kl 00:38 skrev Ronald Record @.***

:

Early tests indicate the problem may be album folder names. Note that the music library structure should be in the form Artist/Album but if an album name contains brackets it fails to get identified properly. For example, I had an artist/album folder named Father John Misty/[2017] Pure Comedy which was not getting added during Setup. I moved the album folder to Father John Misty/Pure Comedy and a subsequent run of Setup identified it properly.

I'm still trying to figure out what folder name characters are legal and how to pass that in the search url for api queries.

Do the albums in your library have something like [year] in the folder names? Or other special characters that might be causing problems?

Still investigating ...

— Reply to this email directly, view it on GitHub https://github.com/doctorfree/Obsidian-Custom-Discogs/issues/1#issuecomment-1728515241, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAASVDJDUQG56QUWJNYBAO3X3NV7VANCNFSM6AAAAAA5AKEEFY . You are receiving this because you authored the thread.Message ID: @.***>

[TobbeT]

I did a new scan after I removed the year. Now its working better. One issue left, it doesnt like the spelling of AcDc like this or AC/DC this. I skall remove the / and try again. But I wonder why my two album that got scan in the first place when they had year in the album title?

Den tors 21 sep. 2023 00:38Ronald Record @.***> skrev:

Early tests indicate the problem may be album folder names. Note that the music library structure should be in the form Artist/Album but if an album name contains brackets it fails to get identified properly. For example, I had an artist/album folder named Father John Misty/[2017] Pure Comedy which was not getting added during Setup. I moved the album folder to Father John Misty/Pure Comedy and a subsequent run of Setup identified it properly.

I'm still trying to figure out what folder name characters are legal and how to pass that in the search url for api queries.

Do the albums in your library have something like [year] in the folder names? Or other special characters that might be causing problems?

Still investigating ...

— Reply to this email directly, view it on GitHub https://github.com/doctorfree/Obsidian-Custom-Discogs/issues/1#issuecomment-1728515241, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAASVDJDUQG56QUWJNYBAO3X3NV7VANCNFSM6AAAAAA5AKEEFY . You are receiving this because you authored the thread.Message ID: @.***>

[doctorfree]

I've modified the Discogs query search terms and now have success matching albums with the year in the album folder name. It first does a query with the full album folder name and if that does not match it then queries with the modified folder name. That seems to work well but I need to perform additional tests.

Your two album matches with a year in the folder name were probably due to the Discogs database also having a year in the album name. I am guessing.

I should have a new release for you to try in a few days. In the mean time, you can test with the modified search query by cloning the repository rather than downloading the release vault:

git clone https://github.com/doctorfree/Obsidian-Custom-Discogs.git
cd Obsidian-Custom-Discogs
./Setup -L /path/to/library -v My_Test_Vault