doctormo / python-gitlab3

Python wrapper for the entire GitLab API
GNU Lesser General Public License v3.0
46 stars 25 forks source link

work with Gitlab 8.* (api v3) || add list of group project || add ldap manage #31

Closed LegallGuillaume closed 7 years ago

LegallGuillaume commented 7 years ago

compatible with Gitlab 8.*

ALL projects from a group:

projects_list = gl.group(name).projects()

result is: [{projectGitlabOject1}, {projectGitlabOject2}, {projectGitlabOject3}]

LDAP management: add LDAP to group:

group(name).add_ldap(LDAP_CN, group_access=LDAP_GROUP_ACCESS, provider=LDAP_PROVIDER)

remove LDAP to group:

group = group(name) group.Ldap(group, group.ldap_group_link).delete()

Thanks Jouve for helping me make these changes

LegallGuillaume commented 7 years ago

@doctormo , do you interessed by this pull request ?

doctormo commented 7 years ago

I'm concerned the version you've changed is an older version and now some things will be reverted in your patch. How did you update the code?

LegallGuillaume commented 7 years ago

I forked your master branch and applied my patch. Before pushing I checked that it still works.

I like sharing, that's why I shared the code I use, if it can help :)

doctormo commented 7 years ago

That's good. There's an open question above in-code. After that, I'll merge in.

LegallGuillaume commented 7 years ago

Great ! For "How did you update the code ?", I don't understand your question

doctormo commented 7 years ago

That is not the question, there are other comments inside the diff, can you see them in github's interface?

LegallGuillaume commented 7 years ago

no I don't see them

LegallGuillaume commented 7 years ago

@doctormo, You sould create a new branch for gitlab 8.* because the master branch is for old version, I use theses modification for my gitlab and it's works fine.