search

doctorray117 / minecraft-ondemand

Templates to deploy a serverless Minecraft Server on demand in AWS
Apache License 2.0
1.72k stars 119 forks source link

Created an EC2 Launch Template, supporting Role and Security Group for ad-hoc maintenance of the EFS. #33

Open teagles opened 2 years ago

doctorray117 commented 2 years ago

Hey this looks great. I'd like to test it out soon and will merge later. Do you want to draft any text for how a user might interface with the instance for file maintenance? I'm slowly but surely working through the CDK docs to be more user friendly. Thanks.

teagles commented 2 years ago

I sure can. Before I do I was tinkering with making it even more user friendly by including an ASG that defaults to 0 capacity so all the user has to do is scale that up and down to activate or deactivate an instance. Would that mode of operation be preferable to using Launch Instance with the template as I'm using it now?

teagles commented 2 years ago

Actually I just remembered why I didn't do that initially. It would require more mandatory Config to pre-seed an ssh key. I'll instead focus on an addendum to the docs that outlines the current use.

teagles commented 2 years ago

Added docs with example maintenance commands.

teagles commented 2 years ago

This other pull request makes things even easier but I'll leave it up to you if you want to retain these changes for the proposed option 2.

doctorray117 commented 2 years ago

Hi, thanks, I'll try to review these tomorrow!

doctorray117 commented 2 years ago

I do like the ease of the ecs exec method, I want to get a better understanding on if there are limitations or issues on editing files during runtime though. If it can be done with the cloudshell then I think it's a winner. I do appreciate your work on the launch template and think it's worth including some of it for sure. Apologies for the severe delays on reviewing these, I've been a little busy with work. Thanks.

teagles commented 2 years ago

What I might do if I get time on the weekend (or later) is layering my stuff on the other change with some extra documentation and changes for the cloud shell and offline edit scenarios.