search

doctrine-extensions / DoctrineExtensions

Doctrine2 behavioral extensions, Translatable, Sluggable, Tree-NestedSet, Timestampable, Loggable, Sortable
MIT License
4.01k stars 1.26k forks source link

Another round of mapping refactoring in tests for cross-version compatibility #2738

Closed mbabker closed 6 months ago

mbabker commented 6 months ago

Ref: #2708

We don't need to check for class presence on the ORM's attribute driver, we're well past the version that was introduced as a minimum requirement. Other than that, just some more fixture generation/synchronization and adjusting test setup to always use attributes on PHP 8 instead of hard requiring the annotation driver.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (598fead) 79.33% compared to head (07339d4) 79.26%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2738 +/- ## ========================================== - Coverage 79.33% 79.26% -0.07% ========================================== Files 162 162 Lines 8506 8513 +7 ========================================== Hits 6748 6748 - Misses 1758 1765 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

franmomu commented 6 months ago

thanks @mbabker!