search

doctrine-extensions / DoctrineExtensions

Doctrine2 behavioral extensions, Translatable, Sluggable, Tree-NestedSet, Timestampable, Loggable, Sortable
MIT License
4.03k stars 1.27k forks source link

Doctrine\ORM\Mapping\ClassMetadata::getFieldMapping() will return an object on ORM 3 instead of an array #2765

Closed mbabker closed 7 months ago

mbabker commented 7 months ago

Ref: #2708

Cherry-picks out changes related to moving from an array to the Doctrine\ORM\Mapping\FieldMapping in ORM 3.0.

The compat issues are baselined into the PHPStan config for now since we know the class doesn't exist on 2.18 (which is what SA is running against) and the entire point of this diff is to be a compat layer.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (0632ab1) 78.75% compared to head (141eec3) 78.91%. Report is 5 commits behind head on main.

Files Patch % Lines
src/SoftDeleteable/Mapping/Event/Adapter/ODM.php 40.00% 3 Missing :warning:
src/Timestampable/Mapping/Event/Adapter/ODM.php 40.00% 3 Missing :warning:
src/SoftDeleteable/Mapping/Event/Adapter/ORM.php 85.71% 1 Missing :warning:
src/Timestampable/Mapping/Event/Adapter/ORM.php 85.71% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2765 +/- ## ========================================== + Coverage 78.75% 78.91% +0.16% ========================================== Files 163 163 Lines 8593 8502 -91 ========================================== - Hits 6767 6709 -58 + Misses 1826 1793 -33 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

franmomu commented 7 months ago

thanks @mbabker!