search

doctrine-extensions / DoctrineExtensions

Doctrine2 behavioral extensions, Translatable, Sluggable, Tree-NestedSet, Timestampable, Loggable, Sortable
MIT License
4.03k stars 1.27k forks source link

Run tests without `doctrine/annotations` installed #2781

Closed mbabker closed 3 months ago

mbabker commented 6 months ago

MongoDB ODM 2.7 dropped the hard dependency, so let's do a smoke test build without the annotations package installed here and see what happens...

mbabker commented 6 months ago

@franmomu The PHP 8 builds failing on this PR are all with doctrine/mongodb-odm 2.7 installed, the passing builds on lower versions install 2.5.5. And there weren't any failures on the last CI build for one of my PRs a couple weeks ago with 2.6.3. Did something change in the ODM needing an update here?

franmomu commented 6 months ago

@franmomu The PHP 8 builds failing on this PR are all with doctrine/mongodb-odm 2.7 installed, the passing builds on lower versions install 2.5.5. And there weren't any failures on the last CI build for one of my PRs a couple weeks ago with 2.6.3. Did something change in the ODM needing an update here?

I'm this week AFK, I'll try to take a look at that, but it could be the support of transactions in https://github.com/doctrine/mongodb-odm/pull/2586 that includes some refactors

franmomu commented 6 months ago

@franmomu The PHP 8 builds failing on this PR are all with doctrine/mongodb-odm 2.7 installed, the passing builds on lower versions install 2.5.5. And there weren't any failures on the last CI build for one of my PRs a couple weeks ago with 2.6.3. Did something change in the ODM needing an update here?

I'm this week AFK, I'll try to take a look at that, but it could be the support of transactions in doctrine/mongodb-odm#2586 that includes some refactors

Apparently it is because https://github.com/doctrine/mongodb-odm/pull/2580 (part of https://github.com/doctrine/mongodb-odm/pull/2586), when deferring the clean up of changesets at the of the commit, maybe we are doing something we shouldn't in https://github.com/doctrine-extensions/DoctrineExtensions/blob/8d658b4d22977e3b72f02bfe4e68b2df0ba586aa/src/Tree/TreeListener.php (or there is something wrong with the refactor), I'll try to take a deeper look

franmomu commented 3 months ago

This should work now after https://github.com/doctrine-extensions/DoctrineExtensions/pull/2811

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.43%. Comparing base (0632ab1) to head (9837dfd). Report is 28 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2781 +/- ## ========================================== - Coverage 78.75% 78.43% -0.32% ========================================== Files 163 167 +4 Lines 8593 8614 +21 ========================================== - Hits 6767 6756 -11 - Misses 1826 1858 +32 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

franmomu commented 3 months ago

thanks @mbabker!