search

doctrine-extensions / DoctrineExtensions

Doctrine2 behavioral extensions, Translatable, Sluggable, Tree-NestedSet, Timestampable, Loggable, Sortable
MIT License
4.01k stars 1.26k forks source link

[add-ascii-string-blameable] Allow ascii_string to validTypes #2802

Closed Nirator78 closed 3 weeks ago

Nirator78 commented 1 month ago

Update Gedmo\Blameable\Mapping\Driver\Annotation::validTypes to allow ascii_string. This is my first contribution to an open source project. Thank you in advance for guiding me through the process.

Nirator78 commented 1 month ago

The issue https://github.com/doctrine-extensions/DoctrineExtensions/pull/2802

mbabker commented 1 month ago

Are there other extensions it'd make sense to add ascii_string support to as well? Might as well do it all in one go IMO.

Nirator78 commented 1 month ago

Are there other extensions it'd make sense to add ascii_string support to as well? Might as well do it all in one go IMO.

I hadn't thought of that, but I'll have a look. So I'm closing this pull-request and I'll open another if need be?

mbabker commented 1 month ago

You can add more changes to this PR by committing to the same branch.

Nirator78 commented 1 month ago

You can add more changes to this PR by committing to the same branch.

Done, i found two other class who can need this modification IpTraceable and Sluggable.

Nirator78 commented 4 weeks ago

@mbabker when it can be test then release ?

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.35%. Comparing base (0632ab1) to head (4c412e3). Report is 22 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2802 +/- ## ========================================== - Coverage 78.75% 78.35% -0.40% ========================================== Files 163 167 +4 Lines 8593 8598 +5 ========================================== - Hits 6767 6737 -30 - Misses 1826 1861 +35 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

franmomu commented 3 weeks ago

thanks @Nirator78!