search

doctrine-extensions / DoctrineExtensions

Doctrine2 behavioral extensions, Translatable, Sluggable, Tree-NestedSet, Timestampable, Loggable, Sortable
MIT License
4.01k stars 1.26k forks source link

Add an internal trait to allow cross-version compatibility for ORM hydrators #2804

Closed mbabker closed 3 weeks ago

mbabker commented 1 month ago

Ref: #2708

Similar to #2758 this adds a trait to help with cross-version compatibility, this time for the ORM hydrators and their changed signatures. Flat-out adding return types would be treated as a B/C break, so that can't be done cleanly until a 4.0 release, so this trait helps to cover those changes in an easily replaced way when the bridge is no longer needed.

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 75.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.91%. Comparing base (0632ab1) to head (32b60b3). Report is 20 commits behind head on main.

Files Patch % Lines
src/Tool/ORM/Hydration/HydratorCompat.php 68.42% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2804 +/- ## ========================================== + Coverage 78.75% 78.91% +0.16% ========================================== Files 163 164 +1 Lines 8593 8519 -74 ========================================== - Hits 6767 6723 -44 + Misses 1826 1796 -30 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

franmomu commented 3 weeks ago

thanks @mbabker!