search

doctrine-extensions / DoctrineExtensions

Doctrine2 behavioral extensions, Translatable, Sluggable, Tree-NestedSet, Timestampable, Loggable, Sortable
MIT License
4.03k stars 1.27k forks source link

Misc. ORM 3 compat fixes #2812

Closed mbabker closed 3 months ago

mbabker commented 3 months ago

Ref: #2708

This PR contains a lot of the smaller fixes left over in my running compat branch. With this, theoretically, the next PR is the last one dealing with this all.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 78.12500% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.36%. Comparing base (0632ab1) to head (30568a1). Report is 29 commits behind head on main.

Files Patch % Lines
src/Tree/Strategy/ORM/Closure.php 68.42% 6 Missing :warning:
...ranslatable/Query/TreeWalker/TranslationWalker.php 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2812 +/- ## ========================================== - Coverage 78.75% 78.36% -0.39% ========================================== Files 163 167 +4 Lines 8593 8626 +33 ========================================== - Hits 6767 6760 -7 - Misses 1826 1866 +40 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

franmomu commented 3 months ago

thanks @mbabker!