search

doctrine / DoctrineFixturesBundle

Symfony integration for the doctrine/data-fixtures library
MIT License
2.45k stars 202 forks source link

Return success when no fixtures to load #333

Open simivar opened 3 years ago

simivar commented 3 years ago

Currently, when you run doctrine:fixtures:load and there are no fixtures to load the command returns 1 together with an error message.

In our use-case, we have created a skeleton application that has defined CI/CD templates and pre-installed bundles like this one. One of the steps in our CI is running doctrine:fixtures:load which in new projects that do not have any fixtures yet causes our CI step to fail.

What do you think about one of the possible solutions:

  1. add option to silence error on empty fixtures (--allow-empty or --silence-empty-error)
  2. return warning instead of error when no fixtures to load

I can try to prepare a Pull Request when you see some viable solution.

greg0ire commented 3 years ago

Why not install the bundle but disable it in bundles.php instead?

simivar commented 3 years ago

If I understand you correctly we would have to change our CI/CD scripts too and we don't want to do that. We want to keep them the same as the skeleton ones and they do run doctrine:fixtures:load.