search

doctrine / DoctrineFixturesBundle

Symfony integration for the doctrine/data-fixtures library
MIT License
2.45k stars 202 forks source link

Remove workaround for testing with PHP 8 #344

Closed greg0ire closed 3 years ago

greg0ire commented 3 years ago

Now that all dependencies support it, it should not be necessary to pretend we are using PHP 7.4. Implies upgrading the CS lib.

greg0ire commented 3 years ago

It looks like the integration tests are flaky :facepalm: 

 There was 1 error:

1) Doctrine\Bundle\FixturesBundle\Tests\IntegrationTest::testRunCommandWithPurgeMode
Symfony\Component\DependencyInjection\Exception\InvalidArgumentException: The "doctrine" service is private, you cannot replace it.

/home/runner/work/DoctrineFixturesBundle/DoctrineFixturesBundle/vendor/symfony/dependency-injection/Container.php:169
/home/runner/work/DoctrineFixturesBundle/DoctrineFixturesBundle/Tests/IntegrationTest.php:483