search

doctrine / DoctrineFixturesBundle

Symfony integration for the doctrine/data-fixtures library
MIT License
2.44k stars 202 forks source link

Fixing database "name" (=path) for SQLite #359

Open ThomasLandauer opened 2 years ago

ThomasLandauer commented 2 years ago

Since DBAL 3.0 (see https://github.com/doctrine/migrations/pull/1028), the message currently reads for SQLite:

Careful, database "" will be purged. Do you want to continue? (yes/no)

Neither @Ocramius (see https://github.com/doctrine/dbal/pull/3606#discussion_r292713610) nor me (see https://github.com/doctrine/dbal/pull/4982) succeeded in convincing @morozov to continue returning the file path ;-) So it looks like the fix needs to be done here...

Suggestion: What about adding the platform too? So the message would be:

Careful, MySQL database "foo" will be purged. Do you want to continue? (yes/no)

BTW: doctrine/migrations is currently broken too:

WARNING! You are about to execute a migration in database "" that could result in schema changes and data loss. Are you sure you wish to continue? (yes/no) [yes]:

So when done here, I'm going to submit the same there (i.e. follow up of https://github.com/doctrine/migrations/pull/1028)

morozov commented 2 years ago

@ThomasLandauer please avoid mentioning people or using links to GitHub issues in commit messages. People will get spammed every time this commit is rebased or amended, and the GitHub resources will get linked to each of the rebased or otherwise amended versions.

ThomasLandauer commented 2 years ago

Sorry, didn't know that! So it's OK in the PR message (tab "Conversation" on GitHub's website) but not in the message when doing the actual file change (tab "Commits")?