search

doctrine / DoctrineFixturesBundle

Symfony integration for the doctrine/data-fixtures library
MIT License
2.44k stars 202 forks source link

UserPasswordEncoderInterface depricated #362

Closed Maxime-p closed 2 years ago

Maxime-p commented 2 years ago

Replacing UserPasswordEncoderInterface (depricated since Symfony 5.3) by UserPasswordHasherInterface

Maxime-p commented 2 years ago

Thanks for your first PR in this repository. All in all this is a valid change and approvable, but the used UserPasswordHasherInterface interface and the component it belongs to is something that was introduced in Symfony 5.3, while this bundle still supports Symfony >3.4. It won't work for too many people.

Ok, so can we do something else than waiting? Sorry I'm new in the contributing world ^^

greg0ire commented 2 years ago

IMO For docs, with should assume Symfony 6, DBAL 3, and PHP 8.1 or whatever the latest versions are when we write the docs. Let's be nice to people who did the homework instead of giving them more deprecations to fix.