search

doctrine / DoctrineFixturesBundle

Symfony integration for the doctrine/data-fixtures library
MIT License
2.44k stars 202 forks source link

Fix build #368

Closed hlecorche closed 2 years ago

hlecorche commented 2 years ago

Fix #367

greg0ire commented 2 years ago

Nice job! Please improve your commit message according to the contributing guide. It's hard to understand what you did and why.

greg0ire commented 2 years ago

The Psalm failures look weird :thinking:

hlecorche commented 2 years ago

The Psalm failures look weird 🤔

Yes, where does it see the word object?

stof commented 2 years ago

Probably in a dependency using the object typehint that is not valid on PHP 7.1, because the job installs deps for PHP 8.0 but analyses for PHP 7.1

hlecorche commented 2 years ago

I fixed the CS. I would do a squash at the end.

hlecorche commented 2 years ago

@stof Is it a good solution to add phpVersion="8.0" in psalm.xml file ? Thanks.

With this addition, the problem is solved.

stof commented 2 years ago

Well, analyzing based on PHP 7.1 is expected, as that's what the code needs to support. but that job should configure composer to resolve deps compatible with 7.1

hlecorche commented 2 years ago

@stof I can replace

jobs:
  static-analysis:
    uses: "doctrine/.github/.github/workflows/static-analysis.yml@1.1.1"

By

jobs:
  static-analysis:
    uses: "doctrine/.github/.github/workflows/static-analysis.yml@1.1.1"
    with:
      php-version: "7.1"

Everything will be executed in PHP 7.1 (Composer + psalm). Is it a good idea ?

derrabus commented 2 years ago

My take on this: #366

derrabus commented 2 years ago

Closing in favor of #366. Thank you for your attempt to fix the CI, though. 👍🏻