search

doctrine / DoctrineFixturesBundle

Symfony integration for the doctrine/data-fixtures library
MIT License
2.44k stars 202 forks source link

chore: add ci tests for php 8.2 #375

Closed Chris53897 closed 1 year ago

Chris53897 commented 1 year ago

bump github action version for checkout 2 => 3

The failing test is not related to php 8.2. If i run tests locally with php 8.2 (and php 8.1) i get different results after each run. range is from 0 to 3 errors.

Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException : You have requested a non-existent service "test.doctrine.fixtures.loader". Did you mean this: "test.doctrine.fixtures_load_command"?

greg0ire commented 1 year ago

Indeed if I re-run the tests, fewer are failing… I don't know why that is.

greg0ire commented 1 year ago

The remaining failure seems similar to https://github.com/doctrine/data-fixtures/issues/414

Chris53897 commented 1 year ago

The remaining PhpStan error should be resolved in a sperate PR in my eyes. WDYT?

greg0ire commented 1 year ago

I agree.

greg0ire commented 1 year ago

Thanks @Chris53897 !