Apply hydrator strategies before type conversion

doctrine / DoctrineModule

Doctrine Module for Laminas

http://www.doctrine-project.org/projects/doctrine-module.html

MIT License

398 stars 269 forks source link

Apply hydrator strategies before type conversion #646

Closed Erikvv closed 6 years ago

Erikvv commented 6 years ago

fixes #639

also:

Renamed test asset SimpleEntity to ByValueDifferentiatorEntity and created a new SimpleEntity which is actually simple, to simplify the test without resorting to the less often used byReference hydration
Changes in ->testObjectIsPassedForContextToStrategies so it still tests what it's supposed to. This test was affected by the same type conversions which caused the regression.

Erikvv commented 6 years ago

I dunno if it's worth to add a separate test for byReference. I checked to see if it works just to be sure and it's ok.

TomHAnderson commented 6 years ago

Please review https://github.com/doctrine/DoctrineModule/pull/647 as it has a direct affect on the work you've done here.

We'll try to knock out all these hydrator issues as a group.

Erikvv commented 6 years ago

Please don't let one depend on the other. This breakage is not related to the implementation of handleTypeConversions, just the order in which it is called.

TomHAnderson commented 6 years ago

These PRs will not depend on each other. Because you're active with an eye on hydrators I'd like your opinion on the other one too.