search

doctrine / DoctrineModule

Doctrine Module for Laminas
http://www.doctrine-project.org/projects/doctrine-module.html
MIT License
398 stars 269 forks source link

PR towards a 4.0 release #681

Closed TomHAnderson closed 4 years ago

TomHAnderson commented 4 years ago

3.0 had incorrect factory interface definitions. That will necessitate a 4.0 release.

In the mean time the 3.0 release is helpful in building the doctrine-orm-module PR

SenseException commented 4 years ago

Can you please elaborate more about what changed and why the need for a release in the next major release is necessary?

TomHAnderson commented 4 years ago

@SenseException Yes. In this AbstractFactory the FactoryInterface should be inherited from Laminas\ServiceManager\Factory\FactoryInterface not Laminas\ServiceManager\FactoryInterface

https://github.com/doctrine/DoctrineModule/blob/master/src/DoctrineModule/Service/AbstractFactory.php

SenseException commented 4 years ago

I only see a change in the laminas/laminas-stdlib dependency, not in a namespace.

SenseException commented 4 years ago

Composer on Scrutinizer seems to run into problems. Any idea how this can be fixed?

TomHAnderson commented 4 years ago

Composer on Scrutinizer seems to run into problems. Any idea how this can be fixed?

I adjusted the composer requirements of doctrine\doctrine-laminas-hydrator and that fixed the package error on Scrutinizer.

TomHAnderson commented 4 years ago

Merged to new develop branch