Feature/coding standard

[TomHAnderson]

This PR upgrades phpunit and phpcs and adds the Doctrine Coding Standard.

phpcs passes with the Doctrine standard.

In making the many changes to make phpcs pass everything that was

/**
 * @param array $something

became

/**
 * @param mixed[] $something

To research the origin of data for each array would be over taxing.

[TomHAnderson]

The arrays were changed from multiline to one line because of Squiz.Arrays.ArrayDeclaration which does not exclude Squiz.Arrays.ArrayDeclaration.MultiLineNotAllowed which does not allow for single array elements to exist on multiple lines.

Do you think this is an oversight in the Doctrine coding-standard?

https://github.com/doctrine/coding-standard/blob/master/lib/Doctrine/ruleset.xml#L415-L429

On Sun, Feb 16, 2020 at 3:35 PM Grégoire Paris notifications@github.com wrote:

@greg0ire commented on this pull request.

In src/DoctrineModule/ConfigProvider.php https://github.com/doctrine/DoctrineModule/pull/683#discussion_r379939636 :

 {

+// phpcs:disable

But… the lines were fine (lower than 120 char) before the changes… were the arrays change from multiline to oneline because of some other rule?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/doctrine/DoctrineModule/pull/683?email_source=notifications&email_token=AADYSYESW37BSWIYHA5Q3CLRDG5RXA5CNFSM4KWAGZVKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCVWIUII#discussion_r379939636, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADYSYGNJGUGIVNOJCSFVILRDG5RXANCNFSM4KWAGZVA .

[greg0ire]

Do you think this is an oversight in the Doctrine coding-standard?

Maybe yeah… this is kind of an edge case