search

doctrine / DoctrineModule

Doctrine Module for Laminas
http://www.doctrine-project.org/projects/doctrine-module.html
MIT License
398 stars 269 forks source link

Fix several coding standard issues #689

Closed gszy closed 4 years ago

gszy commented 4 years ago

This fixes mostly unaligned assignments and unused types.

greg0ire commented 4 years ago

I think there is an issue in .travis.yml: CS_CHECK vs CHECK_CS, that's why the build passes without this PR :joy: It's like that since 4e2a72aab5eb23b428b12cfacd6dcfd48e0a6270

greg0ire commented 4 years ago

CS_CHECK seems to be slightly more popular:

╭─~/dev 
╰$ rg 'CS_CHECK' [Dd]octrine*/.travis.yml 
DoctrineModule/.travis.yml
19:        - CS_CHECK=true

DoctrineORMModule/.travis.yml
34:        - CS_CHECK=true
75:  - if [[ $CS_CHECK == 'true' ]]; then composer cs-check ; fi

DoctrineMongoODMModule/.travis.yml
23:        - CS_CHECK=true
╭─~/dev 
╰$ rg 'CHECK_CS' [Dd]octrine*/.travis.yml
DoctrineMongoODMModule/.travis.yml
69:  - if [[ $CHECK_CS == 'true' ]]; then ./vendor/bin/phpcs --standard=PSR2 ./src/ ./tests/ ./config/ ; fi

DoctrineModule/.travis.yml
47:  - if [[ $CHECK_CS == 'true' ]]; then composer cs-check ; f
greg0ire commented 4 years ago

See my attempt to fix this in #693