doctrine / DoctrineModule

Doctrine Module for Laminas
http://www.doctrine-project.org/projects/doctrine-module.html
MIT License
398 stars 270 forks source link

Add missing provide in composer.json #755

Closed snapshotpl closed 2 years ago

snapshotpl commented 2 years ago

Without this section user cannot install laminas-cache alone (this package provide implementation)

driehle commented 2 years ago

Since we don't have any storage adapter in require section of composer.json (only in require-dev), I don't thnk we should add the suggested provide configuration.

We either need to update docs saying that users need to require their own storage adapters together with DoctrineModule, or we'd need to require at least the memory cache adapter (and probably the filesystem adapter as well). Anyways, docs should probably be updated either way.

snapshotpl commented 2 years ago

What about this adapter https://github.com/doctrine/DoctrineModule/blob/4.3.x/src/Cache/DoctrineCacheStorage.php ?

driehle commented 2 years ago

Ok, forgot about that adapter 👍

driehle commented 2 years ago

Thanks @snapshotpl!