search

doctrine / DoctrineModule

Doctrine Module for Laminas
http://www.doctrine-project.org/projects/doctrine-module.html
MIT License
398 stars 269 forks source link

Cover annotation driver instanciation #777

Closed greg0ire closed 2 years ago

greg0ire commented 2 years ago

It will break when allowing Persistence 3.

driehle commented 2 years ago

Not sure if we should push this in 4.4.x first (which is officially still supported, but will never receive support for persistence 3.0). Technically, PRs should go in the lowest supported branch, but I'll agree that this change will not be relevant before 5.2.0.

greg0ire commented 2 years ago

It's not a big deal for me to retarget I think :)

driehle commented 2 years ago

Looks good! Let's merge this an PR #778 to make a 4.4.2 release.