doctrine / DoctrineModule

Doctrine Module for Laminas
http://www.doctrine-project.org/projects/doctrine-module.html
MIT License
398 stars 270 forks source link

Package incorrectly states that it does provide `laminas/laminas-cache-storage-implementation` #820

Closed boesing closed 10 months ago

boesing commented 11 months ago

As per composer.json, this package is stating that it provides laminas/laminas-cache-storage-implementation via provide. Only packages which do actually provide an implementation should use provide.

There is a good read about dependency inversion here.

Please remove this from the projects composer.json to avoid future problems with incompatibilities between laminas-cache and doctrine/doctrine-module.

TomHAnderson commented 11 months ago

100% @boesing Do you want to provide a PR to put your name in the repo? Else it's a simple fix I'll do promptly.

boesing commented 11 months ago

Created #821, feel free to re-target to 6.0.x in case you want to release this as a patch.

driehle commented 10 months ago

Closed with #821