search

doctrine / DoctrineMongoDBBundle

Integrates Doctrine MongoDB ODM with Symfony
http://symfony.com/doc/current/bundles/DoctrineMongoDBBundle/index.html
MIT License
379 stars 229 forks source link

Move tests to GitHub Actions #660

Closed franmomu closed 3 years ago

franmomu commented 3 years ago

This is based on https://github.com/doctrine/mongodb-odm/pull/2250

I've changed to check just Symfony maintained versions 4.4 and 5.1.

Some doubts:

I don't know if composer global require --no-progress --no-scripts --no-plugins symfony/flex dev-master is necessary. And also about this:

    # Test dev versions
    - php: 7.3
      if: type = cron
      env: DEV COMPOSER_FLAGS="-n --prefer-dist"

The other cases I think they are covered.

greg0ire commented 3 years ago

Please also update the README badge and .gitattributes

greg0ire commented 3 years ago

The line with symfony/flex was introduced by @alcaeus and @chalasr in 8fcefac455608e0f7dfc98ad6eb5de0f19990798 as part of https://github.com/doctrine/DoctrineMongoDBBundle/pull/602 . So was the line with cron.

greg0ire commented 3 years ago

@chalasr can you please review this?

chalasr commented 3 years ago

Installing flex globally used to speed up composer package downloads thanks to parallelized prefetching. That's not useful anymore on Composer 2

greg0ire commented 3 years ago

Discussed with @alcaeus about the cron, and we can ignore it for now.

greg0ire commented 3 years ago

Thanks @franmomu !