search

doctrine / DoctrineMongoDBBundle

Integrates Doctrine MongoDB ODM with Symfony
http://symfony.com/doc/current/bundles/DoctrineMongoDBBundle/index.html
MIT License
379 stars 229 forks source link

PHP8 support #665

Closed rimvislt closed 3 years ago

rimvislt commented 3 years ago

Not sure how to fix coding standards checkout issue

alexislefebvre commented 3 years ago

662 and this issue are duplicates.

rimvislt commented 3 years ago

Should I update code to minimum php 7.3, because php 7.2 is end of live? (https://www.php.net/supported-versions.php)

dbrumann commented 3 years ago

I don't think updating the minimum PHP version should be part of this PR. Since Symfony 5 supports PHP 7.2 it makes sense to keep it unless there is something to be gained from dropping it.

malarzm commented 3 years ago

Should I update code to minimum php 7.3, because php 7.2 is end of live? (https://www.php.net/supported-versions.php)

The best for the bundle is to allow same PHP versions as ODM does: let's keep 7.2 for now. If we are going to drop it we will need to release another ODM version first.

malarzm commented 3 years ago

I'm going to close the PR as I've just merged #662. That PR got chosen because it had all checks passing already. Nevertheless I want to thank you @rimvislt for your work on the issue! :)