doctrine / DoctrineMongoDBBundle

Integrates Doctrine MongoDB ODM with Symfony
http://symfony.com/doc/current/bundles/DoctrineMongoDBBundle/index.html
MIT License
379 stars 229 forks source link

Add compatibility with Symfony 6 #710

Closed franmomu closed 2 years ago

franmomu commented 2 years ago

There are many BC breaks here

Tests will be probably fixed with https://github.com/symfony/symfony/pull/43917

malarzm commented 2 years ago
franmomu commented 2 years ago
  • MongoDBQueryBuilderLoader how this is solved for ORM?

It's in Symfony 😬

jordisala1991 commented 2 years ago

@franmomu it does not seem that your PR (https://github.com/symfony/symfony/pull/43917) is getting merged for 5.4 or 6.0 (it is target to 6.1), does that affect this PR in any way?

We only miss this one to add sf 6 to three more Sonata bundles.

franmomu commented 2 years ago

@franmomu it does not seem that your PR (symfony/symfony#43917) is getting merged for 5.4 or 6.0 (it is target to 6.1), does that affect this PR in any way?

I've written a comment there, thanks for pointing that out.

In any case, that's when using auto_mapping, we can always set it explicitly, I'll try to change it later today or tomorrow to see if it passes the tests.

malarzm commented 2 years ago

@franmomu I think let's add the types everywhere, let's just put it to the UPGRADE file that in an (unlikely ;) ) event somebody did extend our classes, they need to adjust their code. It's a small BC break they'll need to live with :)

franmomu commented 2 years ago

@franmomu I think let's add the types everywhere, let's just put it to the UPGRADE file that in an (unlikely ;) ) event somebody did extend our classes, they need to adjust their code. It's a small BC break they'll need to live with :)

👍 I think it's unlikely to happen too, now we need https://github.com/doctrine/DoctrineMongoDBBundle/pull/713 first

malarzm commented 2 years ago

713 merged :)

franmomu commented 2 years ago

All 🟢 now!

malarzm commented 2 years ago

Thanks @franmomu!