search

doctrine / DoctrineMongoDBBundle

Integrates Doctrine MongoDB ODM with Symfony
http://symfony.com/doc/current/bundles/DoctrineMongoDBBundle/index.html
MIT License
377 stars 229 forks source link

Wire the EntityArgumentResolver #754

Closed HypeMC closed 1 year ago

HypeMC commented 1 year ago

Resolves #753

Despite "Entity" being in it's name, the EntityValueResolver & #[MapEntity] attribute work with MongoDB documents as well, it's just missing the wiring. This PR is basically a copy of https://github.com/doctrine/DoctrineBundle/pull/1554 with some minor adjustments.

malarzm commented 1 year ago

@HypeMC don't mind Psalm's failure (unless you want to), we'll deal with that separately

deluxetom commented 1 year ago

Anything I could help with to get this PR merged? this seems ready to me

franmomu commented 1 year ago

Thanks @HypeMC!

boskos-q commented 1 year ago

Thanks @franmomu for merging this! One more thing, when can we expect for 4.6.x to be released as we'd really need this feature? Also I don't want to sound like an ignorant dev who just asks for a feature, but if there is anything I could do to help for this release to happen, please do tell. I'll be more than happy to do it :)

nicolas-grekas commented 1 year ago

This should be updated to leverage https://github.com/symfony/symfony/pull/48992! (adding attribute "name" on the tag)

franmomu commented 1 year ago

@boskos-q I'm sorry, but we don't really know, I hope it won't take too much. You can always try the 4.6.x branch in your project and that would help us to test next release.

There is also https://github.com/doctrine/DoctrineMongoDBBundle/issues/770 that needs to be addressed.