search

doctrine / DoctrineMongoDBBundle

Integrates Doctrine MongoDB ODM with Symfony
http://symfony.com/doc/current/bundles/DoctrineMongoDBBundle/index.html
MIT License
377 stars 229 forks source link

Update composer.json #766

Closed playmono closed 1 year ago

playmono commented 1 year ago

Update doctrine/mongodb-odm to 2.4.x in order to match function signatures.

This MR aims to fix this issue

Doctrine\ODM\MongoDB\APM\CommandLogger::commandStarted(MongoDB\Driver\Monitoring\CommandStartedEvent $event) should either be compatible with MongoDB\Driver\Monitoring\CommandSubscriber::commandStarted(MongoDB\Driver\Monitoring\CommandStartedEvent $event): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vendor/doctrine/mongodb-odm/lib/Doctrine/ODM/MongoDB/APM/CommandLogger.php on line 47
franmomu commented 1 year ago

Thanks for the PR @playmono, but this is not necessary. The "^2.3" constraint means that the range you can install is >=2.3 and <3.0.0.

If you're not able to install doctrine/mongodb-odm 2.4.3, you can execute the following command to see why:

composer why-not doctrine/mongodb-odm 2.4.3
playmono commented 1 year ago

@franmomu Yes, you are right! Already fixed in my code but I forgot to close this MR :)

Thank you anyway for helping me :)