doctrine / DoctrineMongoDBBundle

Integrates Doctrine MongoDB ODM with Symfony
http://symfony.com/doc/current/bundles/DoctrineMongoDBBundle/index.html
MIT License
377 stars 229 forks source link

fix: UniqueEntity::$service is considered final #777

Closed divine closed 1 year ago

divine commented 1 year ago

Fix #741.

franmomu commented 1 year ago

Thanks @divine! what about using the suggested approach by symfony:

Public and protected properties are now considered final; instead of overriding a property, consider setting its value in the constructor

That way a user can use Unique with their own service without overriding the class (I guess it unlikely to happen, but it could happen)

divine commented 1 year ago

Does it look better now?

Thanks!

malarzm commented 1 year ago

Thanks @divine and @franmomu!

divine commented 10 months ago

Hello,

Any ETA for a new release with this fix?

Thanks!

malarzm commented 10 months ago

Here you go :) https://github.com/doctrine/DoctrineMongoDBBundle/releases/tag/4.6.1