doctrine / DoctrineMongoDBBundle

Integrates Doctrine MongoDB ODM with Symfony
http://symfony.com/doc/current/bundles/DoctrineMongoDBBundle/index.html
MIT License
377 stars 229 forks source link

Update ServiceRepositoryTrait with missing ManagerRegistry param #782

Closed mustanggb closed 10 months ago

mustanggb commented 10 months ago

Using static analysis gives the error:

Expected type 'Doctrine\Persistence\ManagerRegistry'. Found 'Doctrine\ODM\MongoDB\DocumentManager'
@param \Doctrine\ODM\MongoDB\DocumentManager $registry
mustanggb commented 10 months ago

Opened #783 for the unrelated Static Analysis failure.

malarzm commented 10 months ago

@mustanggb thanks for the PR! I've taken care of the fail you've mentioned, thanks for pointing me to a dangling PR. That also made me realize that your PR was targeted at wrong branch, I've changed it to 4.6.x so we'll be able to release that as a bugfix sooner than later.

Would you mind:

mustanggb commented 10 months ago

Would you mind:

  • rebsing your branch atop 4.6.x
  • squashing your commits
  • add a more meaningful commit message? PR's title is a good candidate :)

Done.

malarzm commented 10 months ago

Thanks @mustanggb!