Deprecate `fixture_loader` option - Githubissues

doctrine / DoctrineMongoDBBundle

Integrates Doctrine MongoDB ODM with Symfony

http://symfony.com/doc/current/bundles/DoctrineMongoDBBundle/index.html

MIT License

377 stars 229 forks source link

Deprecate `fixture_loader` option #790

Closed franmomu closed 9 months ago

franmomu commented 9 months ago

ContainerAwareLoader class is deprecated in Symfony 6.4 (and removed in 7.0) and looking at the usages I bumped into fixture_loader option.

This option was introduced long time ago in https://github.com/doctrine/DoctrineMongoDBBundle/commit/5a1208c18f77fa9d85420d68a3ad40533133f5ce and it was used to instantiate that fixture loader in LoadDataFixturesDoctrineODMCommand.

Right now this option apparently is only used to set this parameter: https://github.com/doctrine/DoctrineMongoDBBundle/blob/e8bc04817874b9b63971fd3cea5f1d1dac145b30/DependencyInjection/DoctrineMongoDBExtension.php#L98-L99

But we don't use this parameter since 3.6 in https://github.com/doctrine/DoctrineMongoDBBundle/pull/529 (correction: in 3.6 was still used but in a deprecated path that was removed in 4.0)

I decided to apart from deprecating the option, to remove the parameter (I can re-add it) which I guess/hope no one is using it (they shouldn't).

malarzm commented 9 months ago

Thanks @franmomu!