search

doctrine / DoctrineMongoDBBundle

Integrates Doctrine MongoDB ODM with Symfony
http://symfony.com/doc/current/bundles/DoctrineMongoDBBundle/index.html
MIT License
377 stars 229 forks source link

Mark all command and compiler pass classes as final #796

Closed GromNaN closed 8 months ago

GromNaN commented 8 months ago

All the commands are glue code for Doctrine features. If some needs to change the behavior of a command, they can duplicate the code. Maintenance is a lot easier when this classes are marked internal, as we don't have to keep backward-compatibility.

GromNaN commented 8 months ago

@franmomu maybe we should mark them internal in 4.7 and final in 5.0. So this breaking change can be reported before upgrading to the major version.

franmomu commented 8 months ago

@franmomu maybe we should mark them internal in 4.7 and final in 5.0. So this breaking change can be reported before upgrading to the major version.

yeah, we should warn users 👍

GromNaN commented 8 months ago

The classes are now internal in 4.7, and this PR mark them as final in 5.0