search

doctrine / DoctrineMongoDBBundle

Integrates Doctrine MongoDB ODM with Symfony
http://symfony.com/doc/current/bundles/DoctrineMongoDBBundle/index.html
MIT License
377 stars 229 forks source link

Revert "Add $buildDir parameter to warmUp method" #798

Closed franmomu closed 8 months ago

franmomu commented 8 months ago

This reverts commit dc54819096a2e57b4d04dca3fd9e275d37024e46.

Since we are not adding BC breaks in 4.7, should we maybe revert this commit? which was the only one adding a BC break in https://github.com/doctrine/DoctrineMongoDBBundle/pull/789

GromNaN commented 8 months ago

Sure. And let's re-apply in 5.0.x

GromNaN commented 8 months ago

Actually, cache warmers should be @internal too.

franmomu commented 8 months ago

Actually, cache warmers should be @internal too.

Yep, I'm make them and ignore the direct deprecation

franmomu commented 8 months ago

Actually, cache warmers should be @internal too.

Yep, I'm make them and ignore the direct deprecation

They already are

GromNaN commented 8 months ago

They already are

Then, you don't have to revert. Changing internal classes is never a breaking change.

franmomu commented 8 months ago

They already are

Then, you don't have to revert. Changing internal classes is never a breaking change.

But it was marked as internal in 4.4, someone could upgrade from 4.3 to 4.7

GromNaN commented 8 months ago

Alright.

GromNaN commented 8 months ago

Thank you @franmomu

GromNaN commented 8 months ago

There was a conflict when upmerging into 5.0.x, I kept the modified changes, so we don't have to reapply this breaking changes for the new major version. See https://github.com/doctrine/DoctrineMongoDBBundle/commit/a4903da062b1f23b8672a87afc793aa19c5bd9b0