search

doctrine / DoctrineMongoDBBundle

Integrates Doctrine MongoDB ODM with Symfony
http://symfony.com/doc/current/bundles/DoctrineMongoDBBundle/index.html
MIT License
377 stars 231 forks source link

Drop support for Doctrine cache adapter for metadata #804

Closed GromNaN closed 6 months ago

GromNaN commented 7 months ago

Remove BC layer introduced in #690 to keep support for Doctrine cache adapters. PSR-6 is now required.

GromNaN commented 7 months ago

@Ahummeling, you introduced this compatibility layer, I'd be glad to have your review if you can find the time.

franmomu commented 7 months ago

There are also these class definitions involved:

https://github.com/doctrine/DoctrineMongoDBBundle/blob/ddf39bb974080d82325eff633dba7ce8c874a5ad/Resources/config/mongodb.xml#L22-L30

I don't know (I haven't properly checked) if changing them would also allow us to remove:

https://github.com/doctrine/DoctrineMongoDBBundle/blob/ddf39bb974080d82325eff633dba7ce8c874a5ad/DependencyInjection/DoctrineMongoDBExtension.php#L580-L650

since apparently these classes are used by AbstractDoctrineExtension.

Ahummeling commented 7 months ago

@Ahummeling, you introduced this compatibility layer, I'd be glad to have your review if you can find the time.

It's been a while since I've touched this code, I might be able to find some time over the weekend. It was quite a complex task, so would like to take the time for it to properly review this.

GromNaN commented 6 months ago

@alcaeus @franmomu I updated the extension and service definitions to not rely on the abstract extension from doctrine-bridge.