search

doctrine / DoctrineMongoDBBundle

Integrates Doctrine MongoDB ODM with Symfony
http://symfony.com/doc/current/bundles/DoctrineMongoDBBundle/index.html
MIT License
377 stars 231 forks source link

Backport UPGRADE-5.0 #827

Closed GromNaN closed 6 months ago

GromNaN commented 6 months ago

I'm not sure why we maintain this file in the previous branch. We decided to no longer do that in Symfony (see UPGRADE-7.0 on branch 6.4)

malarzm commented 6 months ago

To me it's easier this way. In one PR you can introduce

Othwrwise "killing notes" would need to be done retroactively upon major release.

malarzm commented 6 months ago

Ah never mind, just saw what Symfony is doing. I'm quite OK with that :)

GromNaN commented 6 months ago

What's better? Update it or remove it?

In case of update, I'll take https://github.com/doctrine/DoctrineMongoDBBundle/pull/828 changes.

malarzm commented 6 months ago

@franmomu @IonBazan @alcaeus thoughts please? :)

alcaeus commented 6 months ago

I'm fine with both - whatever is less friction TBH.

franmomu commented 6 months ago

I'm fine with what Symfony does 👍