search

doctrine / DoctrineORMModule

Doctrine ORM Module for Laminas
https://www.doctrine-project.org/projects/doctrine-orm-module.html
MIT License
438 stars 229 forks source link

Allow symfony/console ^6.0.0 #693

Closed fezfez closed 2 years ago

fezfez commented 2 years ago

@greg0ire : i think it's because it depend on https://github.com/doctrine/DoctrineModule/pull/756

greg0ire commented 2 years ago

Let's put this PR on hold until that other one is merged and released then.

fezfez commented 2 years ago

@greg0ire : no problem ;)

driehle commented 2 years ago

DoctrineModule 4.4.0 with support for symfony/console ^6.0 is released. Please check again if it now works with DoctrineORMModule as well.

fezfez commented 2 years ago

@driehle : seem to work : https://github.com/doctrine/DoctrineORMModule/runs/4383192912?check_suite_focus=true

driehle commented 2 years ago

Looks good 👍 

 - Locking symfony/console (v6.0.0)

Could you please squash your commits?

fezfez commented 2 years ago

@driehle : done

greg0ire commented 2 years ago

Locking symfony/var-dumper (v5.4.0) what's blocking the upgrade to 6.0.0?

driehle commented 2 years ago

Not our fault 😇 

driehle:~/DoctrineORMModule$ composer why symfony/var-dumper
laminas/laminas-developer-tools  2.2.0  requires  symfony/var-dumper (^5.0.1)

Oh, and snapshotpl was faster than me opening a PR a laminas-developer-tools 😄

snapshotpl commented 2 years ago

@driehle not related, but lucky!