search

doctrine / DoctrineORMModule

Doctrine ORM Module for Laminas
https://www.doctrine-project.org/projects/doctrine-orm-module.html
MIT License
437 stars 229 forks source link

Add support for schema assets filter option #709

Closed villermen closed 2 years ago

villermen commented 2 years ago

$filterSchemaAssetsExpression was deprecated, but its $schemaAssetsFilter callback replacement hasn't been implemented in doctrine-orm-module yet. This PR tries to correct that by defining the option on Configuration.

If there is any additional documentation/testing needed just point me in the right direction and I'll get that sorted!

SenseException commented 2 years ago

In case of documentation: https://github.com/doctrine/DoctrineORMModule/blob/5.1.x/docs/en/configuration.rst

villermen commented 2 years ago

I've added a unit test and documentation example!

driehle commented 2 years ago

@villermen Could you please rebase your changes on the latest 5.1.x branch? This should solve the broken CI pipelines.

villermen commented 2 years ago

@driehle Done!

driehle commented 2 years ago

Thank you for your time and contribution, @villermen!

It will probably take a few days for the release of 5.1.0 though, but you can give 5.1.x-dev a try if you like.