Closed tomudding closed 1 year ago
I am aware of the failing tests, I will address these in a bit.
seem good to me :1st_place_medal:
This may require bumping
laminas/laminas-servicemanager
to at leastv3.11.0
, @driehle please advise.
Indeed, we need to bump laminas-servicemanager to the version introducing class aliases for the interop and the Psr containers. For the records, boesing has explained this here: https://github.com/php-fig/container/issues/37
Please bump to ^3.17.0. Otherwise this PR looks fine.
Please bump to ^3.17.0. Otherwise this PR looks fine.
I have amended my first commit to bump the version to ensure correct history. Thank you for your time taking a look at this :)
As suggested in #728 this drops the abandoned
container-interop/container-interop
in favour ofpsr/container
. This means that theInterop\Container\ContainerInterface
interface is replaced withPsr\Container\ContainerInterface
.Unlike doctrine/DoctrineModule#792 not all changed signatures are in
final
classes, specifically theCliConfigurator
. This may require bumpinglaminas/laminas-servicemanager
to at leastv3.11.0
, @driehle please advise.