search

doctrine / DoctrineORMModule

Doctrine ORM Module for Laminas
https://www.doctrine-project.org/projects/doctrine-orm-module.html
MIT License
439 stars 229 forks source link

Fix PHPStan failures. #736

Closed demiankatz closed 1 year ago

greg0ire commented 1 year ago

Does this impact 5.4.x only? Or is 5.3.x impacted as well?

demiankatz commented 1 year ago

@greg0ire, I haven't tested earlier branches and am not currently in a position to do it (upgrading my VM, which will be tied up for the rest of the day)... but it would be easy enough to find out by checking out the branch and running composer run phpstan if you don't mind. :-)

greg0ire commented 1 year ago

The answer is a clear yes. Let me rebase and retarget your branch.

demiankatz commented 1 year ago

Thanks, @greg0ire!

greg0ire commented 1 year ago

Thanks @demiankatz !