search

doctrine / DoctrinePHPCRBundle

This bundle integrates Doctrine PHPCR ODM and PHPCR backends into Symfony
http://phpcr.github.com
MIT License
156 stars 66 forks source link

Add return types for Jackalope 2.0 compatibility #369

Closed alexander-schranz closed 1 year ago

alexander-schranz commented 2 years ago

Related PR:

dbu commented 1 year ago

the jackalope builds are green, finally found the remaining issues :sweat_smile:

i plan to do MRs on this and phpcr utils and phpcr shell to use the wip-branches to see if there is any issue before merging jackalope itself.

do you see any problems with merging this MR? i think it can be merged as is, to be forward compatible (php allows the extending class to be more restrictive about the return type than the parent class is, so this changes works fine with jackalope version 1)

alexander-schranz commented 1 year ago

@dbu sure dont see any problems merging this!